Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm incredibly impressed with this module. Thanks so much for all your efforts and for releasing it for everyone to use. I think there is a bug here, but I'm not completely convinced so proposing the basic change and I'm happy to put more effort in if you can guide me to where it's needed.
My use case is a tool that can make highly configurable requests, and one of the configuration options is whether to use H1 or H2. I am then setting up a fetch-h2 context using:
So, I don't want fetch-h2 to negotiate a protocol for me, I want to pin to a particular one. However, I found that regardless of the value of the
httpsProtocols
option, fetch was always using H2 anyway. I believe the problem is that this conditional check is incorrectly inverted.