Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance tests #129

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Add performance tests #129

wants to merge 17 commits into from

Conversation

akrzgc
Copy link
Contributor

@akrzgc akrzgc commented Oct 19, 2023

This branch is adding performance tests for nanoDFT.

So far it is possible to just execute initial 5 tests with simple purest command purest tests/test_benchmark_performance.py.

The code injecting the ipu_cycle_count into the _nanoDFT() jitted method is WIP.

The branch is going to:

  • add nanoDFT() performance evaluation with ipu_cycle_count
  • use pytest for performance testing
  • add new fullerene molecules such as C80 or C100
  • consider using GitHub Action benchmark for performance tracking (either already within this branch or as a separate change)
  • refactor the ipu_cycle_count code and move it to utils

@akrzgc akrzgc requested a review from balancap October 19, 2023 15:40
Copy link
Contributor

@hatemhelal hatemhelal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An idea to capture the cycle count measurement would be to make it a function decorator. That way we could reuse it outside of nanoDFT as I imagine it would be useful to define micro-benchmarks. I have a preference to break things down into smaller PRs but lets discuss.

Comment on lines +3 to +5
filterwarnings =
error
ignore::DeprecationWarning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't familiar with these options, looks useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants