Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third Wave Water Images and Use Authorization. #704

Merged
merged 2 commits into from
May 9, 2024

Conversation

bigdaub
Copy link

@bigdaub bigdaub commented May 9, 2024

Third Wave water authorizes the use of these images in the Beanconqueror app and any Beanconqueror marketing.
beanconqueror-third-wave-water-classic-light-roast-profile
beanconqueror-third-wave-water-cold-brew-profile
beanconqueror-third-wave-water-dark-roast-profile
beanconqueror-third-wave-water-espresso-machine-profile
beanconqueror-third-wave-water-low-acid-profile
beanconqueror-third-wave-water-medium-roast-profile
beanconqueror-third-wave-water-logo

Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

graphefruit added a commit that referenced this pull request May 9, 2024
… the preparation methods, to add a specific or custom one.
@graphefruit graphefruit merged commit 924cadf into graphefruit:release/v7.2.1 May 9, 2024
5 checks passed
@graphefruit
Copy link
Owner

Thanks for the PR and the images to use!
They have been implemented in ticket #705 :)

graphefruit added a commit that referenced this pull request Jun 28, 2024
* #704, #705 Add third wave water profiles, and make water section like the preparation methods, to add a specific or custom one.

* We removed in lokalise all old translations to make some more cleanup.

* Preset third wave water translations

* Changed font size

* Resetting smoothedValue when attaching to the scale flow

* #709, #708, #707, #706

Added haptic engine
added text to speech for bluetooth scale connection
added sort of images
added indicator that machines are connected

* #710 - toggle hour and minutes

* #711 - Enable tare again on brew timer start when pressure or temperature threshold is hit cause of logic changes

* #712 - Unarchive a bean

* #713 - Focus seconds directly when opening the timer

* #714 - Save again the brew when the while brewing is shown

* #715 - Send EY to visualizer

* Adding Bookoo devices

* Adding translations

* Corrected identifier name, testDeviceScan corrected, aswell as searching the pressure devices to find the bookoo pressure

* Swiching to nativestorage back

* Removing splash screens

* Removing splash screen plugin, upgrading to android 13 (jdk 17 now needed). apache/cordova-android#1678

Added kotlin version etc.

Removing splash files, after they are not longer supported with android

* Making text to speech just for IOS possible, aswell as fixing android image choosing with new version update

* update text

* Removed unused function

* Made extraction chart labels translatable (#718)

Co-authored-by: Lars Saalbach <lars.saalbach@googlemail.com>

* Fix typos in Spanish translation (#716)

* update text

* Added first 7.3.0 update texts

* outcomenting the bookoo pressure

* Add new functions for starting Value Transmission

* Use Value Transmission functions depending on timer

* Commiting the pressure changes for the booko

* Fixing the meticulous API data :)

* Adding the strip android permissions, specialy for write storage aswell for:
android.permission.BODY_SENSORS

android.permission.ACTIVITY_RECOGNITION

* Fix pin formater for beans

* Set final weight for meticulous

* Updating 7.3 patchnotes

* Fixing to the next version

* Fixing iOS image selection

* #721 - Adding download button for brew by weight & retrying the call to the xenia.

* #721 - Fixing null value

* Lokalise update (#724)

* Fixings the MA_STATUS Wait, and wait 2 seconds.
Changing the notes and aromatics to the bottomline

* Lokalise update (#725)

* Lokalise update (#727)

* Enabling pressure sensor, updating to 7.3.0 version tag

* Fix tests after master merge.

* Everywhere: Add missing decalations, imports and providers.
* water-information-card: Add a water.type so Water.getIcon returns.
* app.component: Remove Platform spy because it was missing is function

* #736 - Removing the plugin cause of the core dependency

* Add missing OnDestroy to BrewAddComponent. (#738)

Original fix in b9ffb35 by AdrisGithub.
ngOnDestroy added in 5538f04.

* Remove duplicate text in README.md (#729)

Duplicate text aded in 9d05b7c

Co-authored-by: Grapehfruit <lars.saalbach@googlemail.com>

* Split beforEach calls into async and sync calls.

compileComponents is async so it needs to be in a waitForAsync block. The actual component creation should be in a sync block.
Reference: https://angular.dev/guide/testing/components-scenarios#calling-compilecomponents

* Delete unused import.

setParseTemplateAsSourceFileForTest

* Uncomment CuppingRadarComponent test.

Register chart.js components in the same way as is done in app.component.ts

* Revert changes to plotly.min.js.

This file is imported, it shouldn't have been re-formatted.

* Fix and uncomment graph-display-card.component.spec.ts.

Split beforEach in async and sync.
Clean up formatting.

* UnComment and fix BrewBrewingGraphComponent test.

* Create a MockBrew class that extends Brew and stubs out reading the Preparation from storage.
* Provide MockBrew instance as `data` input.
* In BrewBrewingGraphComponent.getPreparation, delegate to this.data.getPreparation insteda of re-implementing reading from storage. This allows for stubbing the storage read in a single palce.
* Split beforeEach in async and sync sections ref: https://angular.dev/guide/testing/components-scenarios#calling-compilecomponents

---------

Co-authored-by: Grapehfruit <lars.saalbach@googlemail.com>
Co-authored-by: randomcoffeesnob <ydietler@gmail.com>
Co-authored-by: agubelu <agubelu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants