-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn-by-Turn Voice Navigation in the Browser #279
Open
karussell
wants to merge
374
commits into
master
Choose a base branch
from
navi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from the device sometimes)
1 task
nemoneph
reviewed
Sep 19, 2024
} | ||
|
||
export function meterToFt(value: number) { | ||
return value / 0.3048 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karussell I have a doubt, the good formula is rather : meterToFt => value * 3,28084 ?
same for meterToMiles (value * 1609.34) or I'm wrong ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a turn-by-turn navigation feature to the website and it is also bundled as an app on fdroid store (see other repo).
Basically the only difference is a new "navigate" button for the selected path. Clicking on it will start a simple turn-by-turn navigation in the browser with voice instructions, keeping the screen active and the update the recent GPS location.
Try it out at https://navi.graphhopper.org
This work started a long time ago from the knowledge that something like this should be possible (thanks @fabrik42) or telenav :). And also the belief that this is good for us when we can use our own route results in real world, especially in combination with custom profiles, where no other navigation solution can be used as alternative. And as we won't invest in native app development this seem to be a good solution. And recently I refactored this work, so that is no longer a "hack".
Features:
Several browser APIs are used:
TODOs now:
TODOs later:
dark-matter
from mapilion. See Dark mode #308. But this requires a code change toWith stadia maps this works, so we could use their satellite maps and remove MapTiler. Stadia Maps also has a dark style.
related #282