use css for custom model box from local file #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easbar
reviewed
Mar 21, 2023
Comment on lines
-60
to
+62
| modules: true, | ||
| modules: { | ||
| auto: (resourcePath) => resourcePath.endsWith(".module.css") | ||
| }, |
There was a problem hiding this comment.
This means we apply this rule to all css files (see the test property) (except node_modules), but use the modules only for those files ending with .module.css. There are probably other ways to achieve the same, but at least we can use plain css where 'needed' now. We 'need' this now, because we need to control the class names for the codemirror css rules and our current solution is to not use css modules for these css files.
There was a problem hiding this comment.
There are probably other ways to achieve the same
Yeah, I tried changing the "test" regex but without success. Better understanding this would be nice but for now this is clean enough IMO :)
easbar
approved these changes
Mar 21, 2023
Draft
karussell
added a commit
that referenced
this pull request
Mar 29, 2023
…pport dark mode, related to #318
ZeroGxMax
pushed a commit
to minhhpkp/graphhopper-maps
that referenced
this pull request
Nov 12, 2024
ZeroGxMax
pushed a commit
to minhhpkp/graphhopper-maps
that referenced
this pull request
Nov 12, 2024
…pport dark mode, related to graphhopper#318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible to change/overwrite the editor css from here.