Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passthrough onEdit callbacks to the Ruru config with a plugin to update URL query params #1799

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

jvandermey
Copy link

Fixes #1798

Adds onEditQuery and onEditVariables props to the ruru config that are passed through
to the underlying GraphiQLInterface.

Adds a plugin that updates the URL query and variables query params on edits.

Also deprecates the initialQuery and initialVariables props in favor of query and variables.

…o update URL query params

Fixes [graphile#1798](graphile#1798)

Also deprecates the `initialQuery` and `initialVariables` props in
favor of `query` and `variables`.
@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

🦋 Changeset detected

Latest commit: 80ea3fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
postgraphile Patch
ruru-components Patch
ruru Patch
graphile-utils Patch
pgl Patch
graphile Patch
grafserv Patch
graphile-build-pg Patch
@grafserv/persisted Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Josiah VanderMey added 3 commits October 6, 2023 14:17
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.changeset/healthy-kiwis-notice.md Outdated Show resolved Hide resolved
grafast/ruru-components/src/interfaces.ts Outdated Show resolved Hide resolved
grafast/ruru-components/src/interfaces.ts Outdated Show resolved Hide resolved
postgraphile/postgraphile/graphile.config.ts Outdated Show resolved Hide resolved
postgraphile/postgraphile/graphile.config.ts Outdated Show resolved Hide resolved
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally; all working great - thanks @jvandermey! 🙌

@benjie benjie merged commit 8b1f0d1 into graphile:main Oct 9, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support editor and variable change callbacks in the ruru config
2 participants