-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add passthrough onEdit
callbacks to the Ruru config with a plugin to update URL query params
#1799
Conversation
…o update URL query params Fixes [graphile#1798](graphile#1798) Also deprecates the `initialQuery` and `initialVariables` props in favor of `query` and `variables`.
🦋 Changeset detectedLatest commit: 80ea3fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…g via the plugin system; e.g. to update the url search params with the current editor state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally; all working great - thanks @jvandermey! 🙌
Fixes #1798
Adds
onEditQuery
andonEditVariables
props to the ruru config that are passed throughto the underlying
GraphiQLInterface
.Adds a plugin that updates the URL
query
andvariables
query params on edits.Also deprecates the
initialQuery
andinitialVariables
props in favor ofquery
andvariables
.