Fix schema emptying issue from watch mode #1834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1761
There was two bugs in the introspection plugin:
I've refactored the code to separate the side effects from the introspection so that they can be cached separately (side effects to state, introspection to permanent cache) and I've now tracked whether the introspection results are "dirty" or not - if another event arrives before introspection of the DB occurs then we'll mark the introspection as dirty to ensure that it isn't reused.
Performance impact
None known.
Security impact
None known.
Checklist
yarn lint:fix
passes.I've added tests for the new feature, andyarn test
passes.I have detailed the new feature in the relevant documentation.RELEASE_NOTES.md
file (if one exists).