Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orderBy:null regression #1885

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Fix orderBy:null regression #1885

merged 2 commits into from
Dec 9, 2023

Conversation

benjie
Copy link
Member

@benjie benjie commented Dec 9, 2023

Description

Fixes graphile/crystal-pre-merge#487 (probably... I didn't test it).

Performance impact

Negligible.

Security impact

Negligible.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Dec 9, 2023

🦋 Changeset detected

Latest commit: 9e1df08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
graphile-build-pg Patch
postgraphile Patch
graphile-utils Patch
pgl Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit b337bde into main Dec 9, 2023
24 checks passed
@benjie benjie deleted the fix-order-by-null branch December 9, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

V5 - PgConnectionArgOrderByPlugin Regression - Error when passing null in orderBy variable
1 participant