Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test exporting schemas, fix schema exporting #1935

Merged
merged 34 commits into from
Feb 2, 2024
Merged

Test exporting schemas, fix schema exporting #1935

merged 34 commits into from
Feb 2, 2024

Conversation

benjie
Copy link
Member

@benjie benjie commented Feb 2, 2024

Description

Now schemas cannot be exported unless the functions within them don't reference globals, we can test that our standard schemas are exportable in order to catch bugs where we've failed to add EXPORTABLE in various places.

This fixes a few of these places.

Performance impact

The tests run a lot slower now!

Security impact

Improvement: exports more likely to be valid.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Feb 2, 2024

🦋 Changeset detected

Latest commit: 3e2b5b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
tamedevil Patch
graphile-build-pg Patch
graphile-build Patch
postgraphile Patch
graphile-export Patch
grafast Patch
ruru-components Patch
graphile-utils Patch
pgl Patch
graphile Patch
@dataplan/pg Patch
@localrepo/grafast-bench Patch
@dataplan/json Patch
@grafserv/persisted Patch
grafserv Patch
@localrepo/grafast-website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie marked this pull request as ready for review February 2, 2024 14:47
@benjie benjie merged commit fd47d2e into main Feb 2, 2024
24 checks passed
@benjie benjie deleted the test-exports branch February 2, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant