-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test exporting schemas, fix schema exporting #1935
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling the generated factory, it exports it in a way that's compatible with `graphile-export`.
…andling scalars with no parseLiteral definition.
🦋 Changeset detectedLatest commit: 3e2b5b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now schemas cannot be exported unless the functions within them don't reference globals, we can test that our standard schemas are exportable in order to catch bugs where we've failed to add
EXPORTABLE
in various places.This fixes a few of these places.
Performance impact
The tests run a lot slower now!
Security impact
Improvement: exports more likely to be valid.
Checklist
yarn lint:fix
passes.yarn test
passes.I have detailed the new feature in the relevant documentation.RELEASE_NOTES.md
file (if one exists).If this is a breaking change I've explained why.