Mark getDep as protected to avoid abuse #1945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getDep
is an internal API for use within the class only; should other step classes need access to a step's dependencies they should do so via public APIs that the step exposes.🚨 If you were previously using
getDep
on a different class, you'll now need to use the public interfaces instead. There's a significant chance that what you were doing may not have been safe, and may have led to GraphQL spec non-compliance.Fixes #1939
Performance impact
Negligible.
Security impact
None known.
Checklist
yarn lint:fix
passes.I've added tests for the new feature, andyarn test
passes.I have detailed the new feature in the relevant documentation.RELEASE_NOTES.md
file (if one exists).