Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark getDep as protected to avoid abuse #1945

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Mark getDep as protected to avoid abuse #1945

merged 2 commits into from
Feb 7, 2024

Conversation

benjie
Copy link
Member

@benjie benjie commented Feb 7, 2024

Description

getDep is an internal API for use within the class only; should other step classes need access to a step's dependencies they should do so via public APIs that the step exposes.

🚨 If you were previously using getDep on a different class, you'll now need to use the public interfaces instead. There's a significant chance that what you were doing may not have been safe, and may have led to GraphQL spec non-compliance.

Fixes #1939

Performance impact

Negligible.

Security impact

None known.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Feb 7, 2024

🦋 Changeset detected

Latest commit: 9f85c61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@dataplan/pg Patch
grafast Patch
graphile-build-pg Patch
graphile-utils Patch
pgl Patch
postgraphile Patch
@localrepo/grafast-bench Patch
@dataplan/json Patch
@grafserv/persisted Patch
grafserv Patch
ruru-components Patch
@localrepo/grafast-website Patch
graphile-build Patch
graphile-export Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit 30ea122 into main Feb 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

getDep shouldn’t be public
1 participant