Remove GrafastError, introduce flagError()
#2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 099d1db The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…instead use `flagError()` around any value to treat that value as an error. No longer performs `instanceof Error` checks to detect errors in returned values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old system, errors would be wrapped in GrafastError to make detection easier. In the new system we use bit flags to indicate an error, so we don't need this any more. This PR strips out all the GrafastError instances and replaces them with their newer equivalents (flag checks). This also means that errors can now be treated as values, and that things that are not
instanceof Errorcan be used as errors. It also gives a new way to return explicit errors in the form of theflagError()function (alternative methods are to throw the error, or to return a rejected promise, butflagError()works in synchronous cases in the middle of a list without breaking the rest of the list).The special value
$$inhibitedis no longer a symbol, it is now aFlaggedValuesame as the values returned byflagError(). This is more flexible.When trapping an error you now just get the value directly, no need for TrappedError any more (which was never published anyway)
GraphQL resolver emulation is a little more expensive now, and may not work with iterables which yield promises (only with arrays).
🚨 Breaking change: We no longer check for
instanceof Error- you must useflagError()directly if you want to return an error in the middle of a list/batch synchronously. This allows errors to be treated as values (pretty important!) and also means that we don't do expensiveinstanceofchecks which should help performance, perhaps.