Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neater export of resource options #2056

Merged
merged 4 commits into from
May 9, 2024
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented May 9, 2024

Description

Noticed that the Object.fromEntries() was making the exports pretty gross, so I've fixed that.

Performance impact

Marginal, schema build only.

Security impact

Dynamic function, but protected via tamedevil.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: 73aecae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
graphile-build-pg Patch
graphile-build Patch
postgraphile Patch
graphile-utils Patch
pgl Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit 73a059e into main May 9, 2024
36 checks passed
@benjie benjie deleted the neater-export-of-resource-options branch May 9, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant