Fix bug in relational polymorphism where the polymorphic relations were nonsensically added to concrete types #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, refName]` tuple rather than the ref object directly. You can get the old `ref` object via `codec.refs?.[refName]`
…ned. Still feels wrong though.
…ions to each of the concrete types would non-sensically be added to each of the concrete types.
🦋 Changeset detectedLatest commit: f28f6c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benjie
commented
Aug 7, 2024
| @@ -588,6 +591,9 @@ export const PgPolymorphismPlugin: GraphileConfig.Plugin = { | |||
| for (const [relationName, relationSpec] of Object.entries( | |||
| relations, | |||
| )) { | |||
| // Skip over the polymorphic relations | |||
| if (polyRelationNames.includes(relationName)) continue; | |||
There was a problem hiding this comment.
@FelixZY if you're interested; this was the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2085
Performance impact
Negligible.
Security impact
Improvement?
Checklist
yarn lint:fixpasses.yarn testpasses.RELEASE_NOTES.mdfile (if one exists).