fix(postgres): fix processing money type #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think it would be worth using something like https://github.com/openexchangerates/accounting.js for parsing monetary formats? Because you’re right about the localization thing 😉 |
|
Seems overkill; could we just cast the column to float or decimal when selecting? |
|
@calebmer Should we merge this as-is and revisit accounting.js at a later date? I'm just aware that currently the money type doesn't work outside the US for anyone... |
calebmer
approved these changes
Feb 7, 2017
|
Yep 👍 Just waiting for CI to pass now… |
Belline
pushed a commit
to Belline/postgraphql
that referenced
this pull request
Dec 18, 2017
benjie
pushed a commit
that referenced
this pull request
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got around to figuring out what was wrong with the tests for me...
I'm concerned that the removal of commas might be localization dependent too, for example in continental Europe they tend to place commas where we place dots and vice versa; e.g. €1.234,56 - if this is the case for the money type then things are going to go wrong... 😜