Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix startup crash when a non-superuser tries to watch #369

Closed
wants to merge 1 commit into from
Closed

Fix startup crash when a non-superuser tries to watch #369

wants to merge 1 commit into from

Conversation

calebmer
Copy link
Collaborator

Fixes #368

@calebmer calebmer mentioned this pull request Feb 21, 2017
Closed
@calebmer
Copy link
Collaborator Author

Wait, on second thought we aren’t in a transaction so this wouldn’t work, right? (I made this PR through the GitHub editor so I haven’t tested)

The watch fixtures are in a transaction, so we should auto-rollback: https://github.com/calebmer/postgraphql/blob/master/resources/watch-fixtures.sql

@MaienM
Copy link

MaienM commented Feb 22, 2017 •
edited
Loading

I can confirm that this does not fix the issue, unfortunately. As you expected, this throws because we're not in a transaction.

@MaienM MaienM mentioned this pull request Feb 22, 2017
Merged
@calebmer
Copy link
Collaborator Author

calebmer commented Mar 5, 2017

Closing in favor of: #371

@calebmer calebmer closed this Mar 5, 2017
@calebmer calebmer deleted the calebmer-patch-1 branch March 5, 2017 02:53
benjie added a commit that referenced this pull request Jan 27, 2020
@benjie
feat(utils): enable wrapping resolvers matching a filter (#369)
065d5d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebmer @MaienM