-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add procedure support #41
Conversation
Ok, the code for this is pretty much done! 🎉 Computed columns work great. Before I merge and publish this I'm going to write for comments from anybody, and write some docs. If anyone is interested in trying this out, the code is published under |
One thing I haven’t decided on, is should procedures like I'm also thinking about deprecating arguments testing equality in fields like |
Re: whether procedures should return a connection: Yes, definitely, but how do you distinguish between procedures that behave like tables / return rows and others that are helper functions? Other than that, it looks good! |
|
Ok, implementing connections from |
Just finished writing documentation, so if you want to read to learn more about this feature/spell check take a look! I'm super excited about this feature guys 😊 |
hasNextPage | ||
} | ||
totalCount | ||
nodes { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be edges { node { headline, body } }
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nodes
is a little simpler and less intimidating for the README
I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, but returns the same? I've not checked the implementation yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it only returns the list, it's a shortcut if you're not interested in the cursors.
Released in |
This PR adds support for PostgreSQL procedure execution. This will lead to a lot of awesome things like custom search functionality (#31) and authentication (#40) to name a few things that currently have open issues. This also adds a PostgreSQL native extension mechanism.
This PR is almost done, it has support for mutative procedures and query procedures, all that's missing right now is support computed column procedures.
There are a whole bunch of edge cases I'm probably missing so if you guys could try this out in your projects and report back the results that would be awesome 👍. I've published a prerelease on npm at version
1.3.0-beta.0
.Relevant files to get an understanding of how this include: