Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgraphql): Throw an error if jwtSecret is provided without jwtPgTypeIndentifer being provided #466

Merged
merged 8 commits into from
Jun 6, 2017
Merged

fix(postgraphql): Throw an error if jwtSecret is provided without jwtPgTypeIndentifer being provided #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8cc2116
fix(postgraphql): Throw an error if jwtSecret is provided without jwt…
May 16, 2017
66c8ffb
Merge branch 'master' into (fix)_secret_without_token
benjie May 24, 2017
b4a794a
Tweaks
benjie May 24, 2017
e58721f
Remove semicolon
benjie May 24, 2017
bb8f1d2
Merge branch 'master' into (fix)_secret_without_token
benjie May 24, 2017
5f5c297
Adding test
May 30, 2017
afc9078
Merge remote-tracking branch 'origin/(fix)_secret_without_token' into…
May 30, 2017
58c05e5
Merge branch 'master' into (fix)_secret_without_token
benjie Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/postgraphql/__tests__/postgraphql-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,3 +138,8 @@ test('will create a new PostGraphQL schema on when `watchPgSchemas` emits a chan
])
console.log = origLog
})

test('will error if jwtSecret is provided without jwtPgTypeIdentifier', async () => {
const pgPool = new Pool()
expect(() => postgraphql(pgPool, [], { jwtSecret: 'test' })).toThrow()
})
6 changes: 6 additions & 0 deletions src/postgraphql/postgraphql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ export default function postgraphql (
options = schemaOrOptions
}

// Check for a jwtSecret without a jwtPgTypeIdentifier
// a secret without a token identifier prevents JWT creation
if (options.jwtSecret && !options.jwtPgTypeIdentifier) {
throw new Error('jwtSecret provided, however jwtPgTypeIdentifier (token identifier) not provided.')
}

// Creates the Postgres schemas array.
const pgSchemas: Array<string> = Array.isArray(schema) ? schema : [schema]

Expand Down