Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wal2json is now available on Homebrew #548

Closed

Conversation

singingwolfboy
Copy link
Contributor

@benjie
Copy link
Member

benjie commented Oct 31, 2019

Nice! Please can you make the wording more like “if you use homebrew on mac, you can install it with: ...; otherwise on a Unix-based OS you can ...” so that mac users see the original instructions as still valid (e.g. if they don’t use homebrew). Also can you confirm if the homebrew one only runs against homebrew postgres, if so that should also be noted in this text (many people use postgres.app or other alternatives on Mac; the original instructions should work everywhere). Also can you confirm that doing the homebrew install won’t force you to upgrade postgres to the latest (e.g. 12) as this can be a pain to unpick if you’re not expecting it (I’ve lost half a day to this in the past!)

@benjie
Copy link
Member

benjie commented Oct 31, 2019

(The latter is particularly problematic if you have postgis installed as it doesn’t allow the data migration to take place under certain circumstances, e.g. if homebrew deletes the old postgres binaries before you’ve had a chance to migrate the data.)

@singingwolfboy
Copy link
Contributor Author

Also can you confirm that doing the homebrew install won’t force you to upgrade postgres to the latest (e.g. 12)

I'm pretty sure that Homebrew does automatically upgrade dependencies when installing a new package, and postgres is a dependency of wal2json. Maybe it's simpler to just not mention the Homebrew option, given all of these caveats...

@benjie
Copy link
Member

benjie commented Nov 3, 2019

I think that might be wise; alternatively we can just suggest afterwards "wal2json is also available via Homebrew on Mac". I think the current install instructions are probably least likely to cause the user issues 👍

@benjie
Copy link
Member

benjie commented Nov 6, 2019

I'm going to close this for now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants