fix(pagination): fix bug in cursor pagination for PL/pgSQL SETOF functions #559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes graphile/crystal#1171
useAsterisk
runs certain code in a subquery as an optimisation; so:becomes
This is great because it means that PostgreSQL can process the rows in the subquery more efficiently, and doesn't have to execute the "COMPLEX STUFF" until it's thrown most of the rows from "EXPENSIVE THING" away. Less computation = faster queries (even though they're a little more complex).
HOWEVER because we've moved the LIMIT/OFFSET to the subquery, any calls to
row_number()
are now different than they were before because they no longer include the OFFSET. In this code, we add it back in. It's kinda hacky, but it's a performance optimisation so we're just going to have to suck it up 😉