fix(errors): tweaks to errors/logs/etc

packages/graphile-build-pg/package.json

@@ -35,6 +35,7 @@
   "homepage": "https://github.com/graphile/graphile-build#readme",
   "dependencies": {
     "babel-runtime": ">=6 <7",
+    "chalk": "^2.1.0",
     "debug": ">=2 <3",
     "graphile-build": "^0.1.0-alpha.18",
     "graphql-iso-date": "^3.2.0",

packages/graphile-build-pg/src/QueryBuilder.js

@@ -307,8 +307,6 @@ class QueryBuilder {
           // no need to change anything
         }
       } else if (offset > 0) {
-        // eslint-disable-next-line
-        debugger
         throw new Error("Cannot combine 'last' and 'offset'");
       } else {
         if (this.compiledData.orderBy.length > 0) {

packages/graphile-build-pg/src/plugins/PgIntrospectionPlugin.js

@@ -4,6 +4,7 @@ import withPgClient from "../withPgClient";
 import { readFile as rawReadFile } from "fs";
 import pg from "pg";
 import debugFactory from "debug";
+import chalk from "chalk";
 const debug = debugFactory("graphile-build-pg");
 const INTROSPECTION_PATH = `${__dirname}/../../res/introspection-query.sql`;
 const WATCH_FIXTURES_PATH = `${__dirname}/../../res/watch-fixtures.sql`;
@@ -239,11 +240,25 @@ export default (async function PgIntrospectionPlugin(
       await pgClient.query(sql);
     } catch (error) {
       /* eslint-disable no-console */
-      console.warn("Failed to setup watch fixtures in Postgres database");
       console.warn(
-        "This is likely because your Postgres user is not a superuser. If the fixtures already exist, the watch functionality may still work."
+        `${chalk.bold.yellow(
+          "Failed to setup watch fixtures in Postgres database"
+        )} ️️⚠️`
       );
-      console.warn(error);
+      console.warn(
+        chalk.yellow(
+          "This is likely because your Postgres user is not a superuser. If the"
+        )
+      );
+      console.warn(
+        chalk.yellow(
+          "fixtures already exist, the watch functionality may still work."
+        )
+      );
+      console.warn(
+        chalk.yellow("Enable DEBUG='graphile-build-pg' to see the error")
+      );
+      debug(error);
       /* eslint-enable no-console */
       await pgClient.query("rollback");
     }

packages/graphile-build-pg/src/plugins/PgQueryProceduresPlugin.js

@@ -2,6 +2,7 @@
 import type { Plugin } from "graphile-build";
 import makeProcField from "./makeProcField";
 import debugFactory from "debug";
+import chalk from "chalk";
 
 const debugWarn = debugFactory("graphile-build-pg:warn");
 
@@ -71,8 +72,10 @@ export default (function PgQueryProceduresPlugin(builder) {
             } catch (e) {
               // eslint-disable-next-line no-console
               console.warn(
-                `Failed to add function '${proc.namespace
-                  .name}.${proc.name}'; run with 'DEBUG="graphile-build-pg:warn"' to view the error`
+                chalk.bold.yellow(
+                  `Failed to add function '${proc.namespace
+                    .name}.${proc.name}'; run with 'DEBUG="graphile-build-pg:warn"' to view the error`
+                )
               );
               debugWarn(e);
             }

packages/graphile-build/src/makeNewBuild.js

@@ -124,7 +124,7 @@ function ensureArray<T>(val: void | Array<T> | T): void | Array<T> {
 let ensureName = fn => {};
 if (["development", "test"].indexOf(process.env.NODE_ENV) >= 0) {
   ensureName = fn => {
-    if (isDev && !fn.displayName && !fn.name) {
+    if (isDev && !fn.displayName && !fn.name && debug.enabled) {
       // eslint-disable-next-line no-console
       console.trace(
         "WARNING: you've added a function with no name as an argDataGenerator, doing so may make debugging more challenging"
@@ -187,7 +187,7 @@ export default function makeNewBuild(builder: SchemaBuilder): Build {
         console.warn(
           `No scope was provided to new ${getNameFromType(
             Type
-          )}[name=${spec.name}], please check usage of 'newWithHooks'`
+          )}[name=${spec.name}], it's highly recommended that you add a scope so other hooks can easily reference your object - please check usage of 'newWithHooks'. To mute this message, just pass an empty object.`
         );
       }
       if (!Type) {

packages/postgraphile-core/src/index.js

@@ -53,6 +53,14 @@ const getPostGraphQLBuilder = async (
   } = options;
   if (replaceAllPlugins) {
     ensureValidPlugins("replaceAllPlugins", replaceAllPlugins);
+    if (
+      (prependPlugins && prependPlugins.length) ||
+      (appendPlugins && appendPlugins.length)
+    ) {
+      throw new Error(
+        "When using 'replaceAllPlugins' you must not specify 'appendPlugins'/'prependPlugins'"
+      );
+    }
   }
   ensureValidPlugins("prependPlugins", prependPlugins);
   ensureValidPlugins("appendPlugins", appendPlugins);

yarn.lock

@@ -926,7 +926,7 @@ chalk@^1.1.0, chalk@^1.1.1, chalk@^1.1.3:
     strip-ansi "^3.0.0"
     supports-color "^2.0.0"
 
-chalk@^2.0.0:
+chalk@^2.0.0, chalk@^2.1.0:
   version "2.1.0"
   resolved "https://registry.yarnpkg.com/chalk/-/chalk-2.1.0.tgz#ac5becf14fa21b99c6c92ca7a7d7cfd5b17e743e"
   dependencies: