feat(utils): makeExtendSchemaPlugin accepts typeDef array #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
reviewed
Dec 2, 2019
|
This is perfect @jkantr; please can you merge in the latest master (don't rebase), resolve the conflicts and then we're good to merge! 🎉 |
benjie
approved these changes
Dec 10, 2019
benjie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This falls in line a little closer with behavior seen in Apollo server and (I believe) the reference implementation. It also makes it slightly easier to modularize schema extensions local to a project using postgraphile.
First time looking at core of the project, so I hope I got the general idea right. I'm also not super familiar with the graphql AST so if this is too naive of an implementation I can go back to the drawing board :) fwiw it appears to work, and it should maintain order of the typeDefs as in the given array (which I imagine would be the important part).