feat: selectively back-port fixes from master

.eslintignore

@@ -6,3 +6,4 @@ node8plus
 build-turbo
 examples
 dist
+CHANGELOG.md

.eslintrc.js

@@ -9,7 +9,7 @@ module.exports = {
     "plugin:prettier/recommended",
     "prettier/@typescript-eslint",
   ],
-  plugins: ["jest", "flowtype", "graphql"],
+  plugins: ["jest", "flowtype", "graphql", "tsdoc"],
   env: {
     jest: true,
     node: true,
@@ -41,6 +41,7 @@ module.exports = {
     "no-await-in-loop": 0,
     "jest/no-focused-tests": 2,
     "jest/no-identical-title": 2,
+    "tsdoc/syntax": 2,
 
     // Rules that we should enable:
     "@typescript-eslint/no-use-before-define": "warn",

.gitignore

@@ -6,3 +6,5 @@ node_modules
 /.vscode
 *.tgz
 yarn-error.log
+tsconfig.tsbuildinfo
+.env

.travis.yml

@@ -3,6 +3,7 @@ language: node_js
 node_js:
   - "8"
   - "10"
+  - "12"
 
 addons:
   postgresql: "9.4"
@@ -11,8 +12,8 @@ addons:
       - postgresql-server-dev-9.4
 
 env:
-  TEST_DATABASE_URL: postgres://localhost:5432/travis
   PGVERSION: 9.4
+  TEST_DATABASE_URL: postgres://localhost:5432/graphileengine_test
 
 cache: yarn
 
@@ -26,6 +27,7 @@ before_script:
   - sudo service postgresql restart
   - git clone https://github.com/eulerto/wal2json.git
   - sudo bash -c "cd wal2json && USE_PGXS=1 make && USE_PGXS=1 make install"
+  - createdb graphileengine_test
 
 script:
   - scripts/ci
@@ -39,10 +41,30 @@ matrix:
             - postgresql-client-10
             - postgresql-server-dev-10
         postgresql: 10
+      services:
+        - postgresql
       env:
-        - PGPORT=5433
-        - TEST_DATABASE_URL=postgres://travis:travis@localhost:5433/travis
-        - LDS_TEST_DATABASE_URL=postgres://travis:travis@localhost:5433/lds_test
         - PGVERSION=10
+        - TEST_DATABASE_URL=postgres://localhost:5432/graphileengine_test
+        - LDS_TEST_DATABASE_URL=postgres://travis:travis@localhost:5432/lds_test
+        - PGVERSION=10
+      sudo: false
+      dist: xenial
+    - node_js: 12
+      addons:
+        apt:
+          packages:
+            - postgresql-10
+            - postgresql-client-10
+            - postgresql-server-dev-10
+        postgresql: 10
+      services:
+        - postgresql
+      env:
+        - PGVERSION=10
+        - TEST_DATABASE_URL=postgres://localhost:5432/graphileengine_test
+        - LDS_TEST_DATABASE_URL=postgres://travis:travis@localhost:5432/lds_test
+        - PGVERSION=10
+        - GRAPHILE_TURBO=1
       sudo: false
-      dist: trusty
+      dist: xenial

package.json

@@ -34,6 +34,7 @@
     "eslint-plugin-graphql": "^3.0.3",
     "eslint-plugin-jest": "^22.5.1",
     "eslint-plugin-prettier": "^3.0.1",
+    "eslint-plugin-tsdoc": "^0.2.0",
     "eslint_d": "^8.0.0",
     "flow-bin": "^0.106.3",
     "flow-copy-source": "^1.2.0",

packages/graphile-build-pg/src/QueryBuilder.js

@@ -459,7 +459,7 @@ ${sql.join(
   orderBy(
     exprGen: SQLGen,
     ascending: boolean = true,
-    nullsFirst: boolean | null
+    nullsFirst: boolean | null = null
   ) {
     this.checkLock("orderBy");
     this.data.orderBy.push([exprGen, ascending, nullsFirst]);