Remove indcheckxmin check #851
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Had a client's code fail to recognize an index due to this check. Never seen it before, but the risk of ignoring it is minimal (just means the index might not be used, which is always a risk) so we should go with the intent.
Performance impact
Negligible.
Security impact
Negligible; fields exposed by indexes will be exposed slightly earlier than before in some rare cases.
Checklist
yarn lint:fixpasses.I've added tests for the new feature, andyarn testpasses.I have detailed the new feature in the relevant documentation.I have added this feature to 'Pending' in theRELEASE_NOTES.mdfile (if one exists).If this is a breaking change I've explained why.