-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add operation messages via RAISE NOTICE
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased on #17 (after merge to master) to make the diff smaller and more focussed. |
This was referenced Apr 9, 2020
I don’t understand how notices are filtered, it looks like code different from |
👀 I was so tired that day. I wasn't confident merging because I knew I'd overlooked something but couldn't figure out what. Thanks for spotting @mathroc! Added test and fixed. |
demianuco
reviewed
May 23, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12 (cc @demianuco)
PostGraphile will subscribe to
NOTICE
events from PostgreSQL during mutations, and any notice with error codeOPMSG
(operation message) will be added to the mutation payloadmessages
field.Important:
detail
fieldRAISE NOTICE
may have message length limits; it's your responsibility to colour inside the linesclient_min_messages
) to receive NOTICE messages; this is PostgreSQL's default configuration.log_min_messages
) to log NOTICEs then, well, the NOTICEs will be logged; PostgreSQL's default configuration does not log NOTICE.Example: