Upgrade dependencies #25
Conversation
singingwolfboy
force-pushed
the
upgrade-deps
branch
2 times, most recently
from
61df366
to
3a6bb30
Compare
singingwolfboy
force-pushed
the
upgrade-deps
branch
from
3a6bb30
to
e8d3257
Compare
package.json
Outdated
| "graphql": ">=0.6 <15", | ||
| "pg-sql2": "^2.2.1" | ||
| "pg-sql2": "^4.4.3" |
There was a problem hiding this comment.
The change to graphile-build and graphile-build-pg is a breaking change as it says to use the postgis plugin you must be running the latest PostGraphile (where that wasn't previously the case). It's safe to update the yarn.lock (which says which version we're actually using) and the devDependencies but peerDependencies and dependencies must be treated more carefully. For pg-sql2 we want to explicitly state that we support the full range, so:
| "pg-sql2": "^4.4.3" | |
| "pg-sql2": ">=2.2.1 <5" |
There was a problem hiding this comment.
(For graphile-build and graphile-build-pg we already state we support 4.4.4 since ^4.3.0 includes 4.4.0, so we can just change those back to the old values.)
| "debug": "^4.1.1", | ||
| "tslib": "^1.9.3" | ||
| "tslib": "^1.10.0" |
There was a problem hiding this comment.
Despite what I said above, these changes to dependencies are fine 👍
|
IMO the graphile peerDeps should be removed; they cause a bunch of install-time warnings because users generally won't (and shouldn't be encouraged to) have them installed as direct dependencies in their projects. Instead we should use the |
|
@mattbretl Personally, I have no particular preference about your point, but it seems unrelated to this pull request, which is about upgrading dependencies, not removing them. Maybe you could make a separate pull request for your change? |
|
IIRC they're there for TypeScript since we import types from them. If it weren't for that I'd banish them without a second thought. But yes; separate PR 👍 |
Upgrade all the things