fix: Umap duplicate index #489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmeyerov
reviewed
Jun 13, 2023
| @@ -589,10 +589,10 @@ def umap( | |||
| index = res._nodes.index | |||
| if res._node is None: | |||
| logger.debug("-Writing new node name") | |||
| res._nodes[config.IMPLICIT_NODE_ID] = range(len(res._nodes)) | |||
|
|
|||
There was a problem hiding this comment.
Clever
Will this work if cudf?
Will this break somehow downstream if .edges is bound and user was using string name IDs for src dst?
There was a problem hiding this comment.
Strange, I thought this was already done this way...
silkspace
reviewed
Jun 20, 2023
| res = res.nodes( # type: ignore | ||
| res._nodes.reset_index(drop=True) | ||
| .reset_index() | ||
| .rename(columns={"index": config.IMPLICIT_NODE_ID}), |
There was a problem hiding this comment.
Why not just call it __index_umap__ or something that has low prob of collision? then we can keep it safe for cudf?
|
@tanmoyio saw this is dangling, any response on #489 (comment) ? |
|
(ping) |
…nto fix/umap-duplicate-index
|
@tanmoyio afaict there are no fixes in the current version, it got commented out? |
lmeyerov
reviewed
Nov 4, 2023
graphistry/embed_utils.py
Outdated
| @@ -542,7 +542,7 @@ def fetch_triplets_for_inference(x_r): | |||
| def _score(self, triplets: Union[np.ndarray, TT]) -> TT: # type: ignore | |||
| _, torch, _, _, _, _, _, _ = lazy_embed_import_dep() | |||
| emb = self._kg_embeddings.clone().detach() | |||
| if type(triplets) != torch.Tensor: | |||
| if type(triplets) is not torch.Tensor: | |||
There was a problem hiding this comment.
normally these are isinstance(x, Y)
lmeyerov
reviewed
Nov 4, 2023
graphistry/nodexlistry.py
Outdated
| @@ -132,13 +132,13 @@ def xls(self, xls_or_url, source='default', verbose=None): | |||
| p = print if verbose else (lambda x: 1) | |||
|
|
|||
| # source is either undefined, a string, or a (partial) bindings object | |||
| if type(source) == str and source not in self.source_to_mappings: | |||
| if type(source) is str and source not in self.source_to_mappings: | |||
There was a problem hiding this comment.
normally these are isinstance(x, Y)
|
CI failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.