Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.12 nodaemon backport #144

Closed

Conversation

jib
Copy link

@jib jib commented Sep 24, 2013

We run all our carbon daemons under supervisor, and not having this patch is a tremendous performance penalty as it forces us to run in --debug mode, so we backported this fix from master.

Please consider integrating it in the 0.9.x branch so we (and others) can keep up with 0.9.x releases.

@dbeckham
Copy link

Not even a single comment on this? The Internet is filled with people trying to figure out how to deal with the carbon daemons not being able to be reasonably started and stopped using modern process control. Having a --no-daemon options fixes this entirely. Why force people to use Twisted unnecessarily?

@pcn
Copy link

pcn commented Dec 18, 2013

+1 from me. I like this. It just needs to back out the twisted version peg so that the merge can happen.

@deniszh
Copy link
Member

deniszh commented Dec 18, 2013

+1
Not sure if --debug in Twisted has some performance impact, but having proper cli flag is better anyway...

@dbeckham
Copy link

This is a copy/paste from my comment in #191:

I spent some time yesterday researching exactly how to properly control Graphite carbon-cache, as it sits in the v0.9.12 tag, using Upstart and have posted a working config here: https://gist.github.com/dbeckham/8057390

Using the info from carbon/conf.py, carbon/util.py, and the Internet, I've created a twistd script block with the correct options, including a --nodaemon option. The config can be tweaked to send logs to a different destination including stdout, or to run under a specific instance name.

I'll be rolling this out in our Puppet environment shortly, but If anyone has any issues with it, or suggestions for making it better, please comment on the gist.

@dcarley
Copy link

dcarley commented Jan 2, 2014

👍

@pyr
Copy link

pyr commented Jan 20, 2014

this should go in. 🤘

@obfuscurity
Copy link
Member

@jib Would you mind rebasing against 0.9.x and we'll see about finally merging this in?

@obfuscurity obfuscurity added this to the 0.9.13 milestone Aug 14, 2014
obfuscurity added a commit that referenced this pull request Aug 18, 2014
0.9.x nodaemon backport (rebase of #144 to 0.9.x branch)
@obfuscurity
Copy link
Member

Closing this one since we merged in @deniszh's rebased version. @jib thanks for your help with this! ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants