Allow passing AR records to jsonapi_* http operations #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
# 1.0.0 (2025-03-18) ### Bug Fixes * allow current_user and params to remain lazy in rspec contexts ([#25](#25)) ([6ce1e07](6ce1e07)) * jsonapi_included helper may accept symbol keys ([#20](#20)) ([cc3cb2d](cc3cb2d)) * require rspec-core as a dependency of the matchers ([0ea2a92](0ea2a92)) ### Features * alias Node#key? to Node#has_key? ([#24](#24)) ([202aecb](202aecb)) * Allow passing AR records to jsonapi_* http operations ([#22](#22)) ([c5e4b23](c5e4b23)) * Support matching against RSpec's`include` builtin ([#23](#23)) ([1ed6fd0](1ed6fd0))
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
# [1.2.0](v1.1.0...v1.2.0) (2025-03-18) ### Bug Fixes * allow current_user and params to remain lazy in rspec contexts ([#25](#25)) ([6ce1e07](6ce1e07)) * jsonapi_included helper may accept symbol keys ([#20](#20)) ([cc3cb2d](cc3cb2d)) * require rspec-core as a dependency of the matchers ([0ea2a92](0ea2a92)) ### Features * alias Node#key? to Node#has_key? ([#24](#24)) ([202aecb](202aecb)) * Allow passing AR records to jsonapi_* http operations ([#22](#22)) ([c5e4b23](c5e4b23)) * Support matching against RSpec's`include` builtin ([#23](#23)) ([1ed6fd0](1ed6fd0))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: the
jsonapi_*helpers for GET/POST/PUT/PATCH/DELETE each accept a url. In many api specs, the url can be derived from the ActiveRecord record(s) that are created before-hand. This allows the specs to pass the AR records to the jsonapi_* helpers directly and have the URL derived from the model the same way that Rails derives its routing for a given AR model instance.that allows
make_requestsubjects like:jsonapi_get order,jsonapi_put user,jsonapi_delete cardand for index:jsonapi_get products_pathInitial slack discussion: https://graphiti-api.slack.com/archives/C5A4UEMGS/p1658959255745979
The url_for helper still accepts a regular string, so it should be backwards compatible with existing usage.