-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for neutrinos/noise in database creation #174
Conversation
Hey Leon - let's discuss this in person tomorrow. Rasmus |
Just to follow up on this: @RasmusOrsoe, it seems like you have opinions on this, so I'll let the two of you discuss. Let me know if you need anything from me. :) |
Have updated the stopped muon method, as well as changed the naming convention as per conversation with @RasmusOrsoe. I also think the stopped muon method belongs in the i3 extractor with other similar methods rather than utils which primarily deals with file handling. I hope that it is clear what we are naming what, if this needs to be said somewhere else. Also returning a dictionary makes the output far more understandable. Important: Going forward position_x, position_y, position_z for muons will be their final position i.e where they stop. This is the same name as the interaction vertex for neutrinos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi - nice to see the naming change. Some of the checks are not successful though!! @BozianuLeon let me or @asogaard know if you need help
Take old stopped muon function out of imports (now it is inside i3extractor)
@BozianuLeon approved - you may click merge! |
Important fix, database creation will throw an error for muons final position and stopped boolean if database has neutrinos/noise in. Requires the truth extractor to have padded values for final_pos and stopped.
Introduced by me in PR #148, now works with neutrino/noise.
@RasmusOrsoe could we make final_position_xyz for neutrinos the interaction vertex?