-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to cluster by time windows #272
Conversation
Based on DBSCAN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mhaminh,
Thanks for this PR! I think it is a nice feature to have. :) I have added a few suggestions regarding the location of the code.
@mhaminh ping |
Sorry, I've been caught up in a few things, I'll push the updated changes soon |
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:dab:
I added a Coarsening class to cluster by time windows. Basically you first cluster by DOMs, and then use DBSCAN to cluster in time. There's also a small hacky part in there so that everything can be clustered in one go, maybe there's a nicer way to do this. Also you can pass the size of the time window at the initialization of the coarsening class.