Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to cluster by time windows #272

Merged
merged 7 commits into from
Oct 12, 2022

Conversation

mhaminh
Copy link
Contributor

@mhaminh mhaminh commented Aug 30, 2022

I added a Coarsening class to cluster by time windows. Basically you first cluster by DOMs, and then use DBSCAN to cluster in time. There's also a small hacky part in there so that everything can be clustered in one go, maybe there's a nicer way to do this. Also you can pass the size of the time window at the initialization of the coarsening class.

@mhaminh mhaminh requested a review from asogaard August 30, 2022 13:06
Copy link
Collaborator

@asogaard asogaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mhaminh,

Thanks for this PR! I think it is a nice feature to have. :) I have added a few suggestions regarding the location of the code.

src/graphnet/components/pool.py Outdated Show resolved Hide resolved
src/graphnet/models/coarsening.py Outdated Show resolved Hide resolved
src/graphnet/models/coarsening.py Outdated Show resolved Hide resolved
@RasmusOrsoe
Copy link
Collaborator

@mhaminh ping

@mhaminh
Copy link
Contributor Author

mhaminh commented Oct 4, 2022

Sorry, I've been caught up in a few things, I'll push the updated changes soon

mhaminh and others added 6 commits October 6, 2022 13:44
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Co-authored-by: Andreas Søgaard <andreas.sogaard@gmail.com>
Copy link
Collaborator

@asogaard asogaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:dab:

@mhaminh mhaminh merged commit 00aabf6 into graphnet-team:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants