Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor configs and add Configurable class #350

Merged
merged 10 commits into from
Nov 11, 2022

Conversation

asogaard
Copy link
Collaborator

  • Moves ModelConfig from graphnet.models.config to graphnet.utilities.config in anticipation of Add model and data config files #226 and to better share code between Config classes
  • Adds Configurable base class for class that will support config files.
  • Fixes module search in ModelConfig.construct_model that previously only listed already-loaded modules, but now lists all.

@asogaard asogaard merged commit 90f8902 into graphnet-team:main Nov 11, 2022
@asogaard asogaard deleted the model-config branch November 11, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants