Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weights utilities + fix #717

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

Aske-Rosted
Copy link
Collaborator

Adds 2 options for the weight fitter

  • a choice to employ an automatic log10 binning
  • a choice to cap the max single event weight to be x * sum(all_weights) (1>x>0)

Adds an option for the BjoernLow class

  • determine x_low as a percentile of the truth. x_low in this case has to be given as a value between 0 and 1.
  • a fix so that the db_count_norm works as intended.

Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aske-Rosted - I think the changes look good. Two of the doc string lines are too long though ( see code climate). Could you shorten those? The other codeclimate warnings are fine.

@RasmusOrsoe RasmusOrsoe self-requested a review May 28, 2024 09:23
@Aske-Rosted Aske-Rosted merged commit 6837b28 into graphnet-team:main May 29, 2024
13 of 14 checks passed
@Aske-Rosted Aske-Rosted deleted the weight_utils branch May 29, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants