Fixed error related to new model saving/loading method and early stopping method #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asogaard
requested changes
Nov 21, 2021
| @@ -208,7 +208,7 @@ def _forward(self, prediction: Tensor, target: Tensor) -> Tensor: | |||
|
|
|||
| # Formatting prediction | |||
| angle_pred = prediction[:,0] | |||
| kappa = prediction[:,1] | |||
| kappa = abs(prediction[:,1]) | |||
There was a problem hiding this comment.
I don't think this abs statement is necessary, as it would imply that the model (in this case, Task components) might return a negative value for kappa, which would not be meaningful. If that is the case, it should be fixed in the corresponding model/task. Therefore, I suggest we leave it to the model to impose the correct restrictions on the output, and in the loss function(s) assume that inputs are as expected.
There was a problem hiding this comment.
I have removed the abs() from the PR as its besides the point for what this PR does. I do think theres merit to adding the abs(), but lets talk about that some other time
asogaard
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.