Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containerisation #83

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Containerisation #83

merged 3 commits into from
Nov 22, 2021

Conversation

asogaard
Copy link
Collaborator

@asogaard asogaard commented Nov 22, 2021 •
edited
Loading

Add functionality to perform containerised inference for benchmarking/model preservation according to Reco. and Syst. WG convenor guidance. (@thoglu FYI)

Closes #77, closes #78

@asogaard asogaard added the feature New feature or request label Nov 22, 2021
@asogaard asogaard self-assigned this Nov 22, 2021
This was linked to issues Nov 22, 2021
Containerise model for inference on I3 files #78
Closed
Prepare functionality for generating I3Modules based on Models #77
Closed
RasmusOrsoe
RasmusOrsoe approved these changes Nov 22, 2021
View reviewed changes
Copy link
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! I take it the path-as-input works?

@asogaard
Copy link
Collaborator Author

Yes, tried locally and it works like a charm using the --mount argument to docker run as in https://github.com/icecube/gnn-reco/pull/83/files#diff-48ce0882d9c38f47f4679c21f522aa38225a5ecaf85c90c3bf98a4d51d344299R11. The proposed additions are still a bit rough around the edges, but should serve as a good first step. :)

@asogaard asogaard merged commit ddd739b into graphnet-team:main Nov 22, 2021
@asogaard asogaard deleted the containerisation branch November 22, 2021 17:20
@asogaard asogaard mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusOrsoe RasmusOrsoe RasmusOrsoe approved these changes

Assignees

@asogaard asogaard

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Containerise model for inference on I3 files Prepare functionality for generating I3Modules based on Models
2 participants
@asogaard @RasmusOrsoe