-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update graphcast docs #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good!
|
||
## Introduction | ||
|
||
The Graphcast CLI enables sending one-off messages. Currently, its default behaviour is to construct and send a message of type `UpgradeIntentMessage`, which is used for the [Subgraph Upgrade Pre-sync feature](https://docs.graphops.xyz/graphcast/design-principles#subgraph-upgrade-pre-sync) of Subgraph Radio. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no default behavior anymore, subcommand is required.
It would be good to explain how the 2 current subcmd fit together for the presyncing feature
|
||
The Graphcast CLI code is very extensible and could be altered to send any kind of Graphcast-compatible message to the network. | ||
|
||
## Run with Docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps include a paragraph on what to expect when they run this command (potential logs and summaries)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can have a more dedicated page for the presyncing feature overall, with concise description on the ideal flow and interaction of components. like the usage guide you mentioned writing
5aa4500
to
a46ce7a
Compare
a46ce7a
to
03f930d
Compare
sidebar_position: 3 | ||
--- | ||
|
||
# Subgraph upgrade pre-sync feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include a workflow diagram here; you can edit from the existing one graphops/subgraph-radio#6
03f930d
to
318cb66
Compare
318cb66
to
7bbc6a8
Compare
7bbc6a8
to
07aca8d
Compare
07aca8d
to
f56597f
Compare
one-shot-cli
tographcast-cli
and refactor commands to reflect recent updatesindexing-status
subcommandVersionUpgradeMessage
toUpgradeIntentMessage
RATELIMIT_THRESHOLD
config var to variables tableupgradeIntentMessages
query to graphql queries section