Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move misc Graph/Walk property algorithms #54

Merged
merged 17 commits into from
Jul 10, 2013
Merged

Move misc Graph/Walk property algorithms #54

merged 17 commits into from
Jul 10, 2013

Conversation

clue
Copy link
Member

@clue clue commented Jul 7, 2013

  • Move Graph property algorithms to new Algorithm\Property\GraphProperty
  • Move Walk property algorithms to new Algorithm\Property\WalkProperty
  • 100% code coverage
  • Documentation / changelog

Refs #27.

clue added a commit that referenced this pull request Jul 8, 2013
@clue
Add tests ~100% coverage for Graph
0f3902e 
Remaining methods will be moved as part of PR #54
clue added 17 commits July 8, 2013 12:01
@clue
Move graph property algorithms to new Algorithm\Property
3ab5727
@clue
Add tests with 100% coverage for new GraphProperty algorithm
0a96c05
@clue
Move Walk property algorithms to new WalkProperty algorithm
bf34851
@clue
Add WalkProperty::hasLoop() alias (completeness)
39d6b7d
@clue
Fix WalkProperty::hasCycle() by checking correct array of vertices
11e5dff
@clue
Fix accessing invalid graph property due to moving algorithm
b2ede25
@clue
Fix testing digons and triangles due to moving algorithm
51deb08
@clue
Fix checking hamiltonian property in cycles
7d58733
@clue
Fix Walk::isCycle() by rejecting walks with no edges
ba7122c
@clue
Add tests with 100% coverage for WalkProperty algorithm
b9ee495
@clue
Document moved Algorithm\Property
093bcef
@clue
Improve documentation
a341224
@clue
Add documentation for common aliases
643b689
@clue
Add WalkProperty::isCircuit() and lots of examples in documentation
6eb50bd
@clue
Add example graphs to documentation
438836d
@clue
Add tests for WalkProperty::isCircuit() (100% coverage again)
4056938
@clue
Document fixes for Walk properties
5db8930
@clue
Copy link
Member Author

clue commented Jul 8, 2013

All tasks completed, removed WIP marker, ready for review.

@clue clue mentioned this pull request Jul 8, 2013
Closed
clue added a commit that referenced this pull request Jul 10, 2013
@clue
Merge pull request #54 from clue/move-algo-property
2b7db97 
Move misc Graph/Walk property algorithms
@clue clue merged commit 2b7db97 into master Jul 10, 2013
@clue clue deleted the move-algo-property branch July 10, 2013 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@clue