Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up supported networks #276

Merged
merged 8 commits into from
Feb 21, 2023
Merged

Cleaning up supported networks #276

merged 8 commits into from
Feb 21, 2023

Conversation

MichaelMacaulay
Copy link
Contributor

No description provided.

@MichaelMacaulay MichaelMacaulay requested a review from a team as a code owner February 1, 2023 16:41
Web3Slimchance
Web3Slimchance requested changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@Web3Slimchance Web3Slimchance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.
Left some comments 🙏

pages/en/deploying/deploying-a-subgraph-to-hosted.mdx Outdated Show resolved Hide resolved
pages/en/deploying/deploying-a-subgraph-to-hosted.mdx Show resolved Hide resolved
pages/en/deploying/deploying-a-subgraph-to-hosted.mdx Show resolved Hide resolved
pages/en/deploying/deploying-a-subgraph-to-studio.mdx Outdated Show resolved Hide resolved
pages/en/developing/supported-chains.mdx Outdated Show resolved Hide resolved
@Web3Slimchance
Copy link
Contributor

  • The term Supported Networks was chosen as the more agnostic term. IPFS for example, is a network but not a chain .
  • The Subgraph code shows network
  • The CLI uses protocol -> network
  • The API endpoints uses network
  • The internal code uses network
  • The feature-support matrix uses network https://github.com/graphprotocol/indexer/blob/main/docs/feature-support-matrix.md
  • The Hosted Service shows network
  • The Explorer shows Indexed Network
  • The Studio shows Indexed Network

The only place I've noticed Blockchain is when Creating a Subgraph in the studio - otherwise we are using network . I agree that chains is more intuitive to some developers. But, for consistency, I think we should continue using network in the docs.

MichaelMacaulay and others added 5 commits February 17, 2023 12:50
@MichaelMacaulay
Latest updates
098270c 
-Fixed suggestions
-Ensured all hosted service chains are listed
-Chains became networks
@MichaelMacaulay
Merge branch 'main' into cleaning-up-supported-networks
b45b945
@Web3Slimchance
Update developer-faqs.mdx
bb0bb72 
Reverted the change from `networks` to `chains`
@Web3Slimchance
Update supported-networks.mdx
2ba417b 
Added a comment showing that Gnosis is considered `In Beta` on the decentralized network.
@Web3Slimchance
Update supported-networks.mdx
09dcdb1 
All Rinkeby, Ropsten and Kovan subgraphs will be archived on February 25, 2023.
Subgraphs indexing the above three testnets will no longer be queryable after this date.
Updated the copy to make it clearer that the three networks are no longer supported (.. as of 4 days from now, anyway)
Web3Slimchance
Web3Slimchance reviewed Feb 20, 2023
View reviewed changes
Copy link
Contributor

@Web3Slimchance Web3Slimchance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thank you for working on this 🔥

@Web3Slimchance Web3Slimchance merged commit 352c436 into main Feb 21, 2023
@Web3Slimchance Web3Slimchance deleted the cleaning-up-supported-networks branch February 21, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Web3Slimchance Web3Slimchance Web3Slimchance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelMacaulay @Web3Slimchance