Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added querying by subgraph id vs deployment id page #555

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

marcusrein
Copy link
Member

Docs entry comparing querying using Subgraph ID vs Deployment ID

@marcusrein
Copy link
Member Author

Nice clean up @benface. Looking good on my end and ready to merge.

CC @MichaelMacaulay for final review.

Copy link
Contributor

@MichaelMacaulay MichaelMacaulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Looks good to merge!

marcusrein and others added 3 commits January 8, 2024 12:11
…t-id.mdx


+1

Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
…t-id.mdx


+1

Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
@benface benface force-pushed the subgraph-id-deployment-id-update branch from 4019bae to 1e4add6 Compare January 8, 2024 17:11
Copy link

github-actions bot commented Jan 8, 2024

📦 Next.js Bundle Analysis for @graphprotocol/docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 694.39 KB (🟡 +85 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/en/querying/querying-by-subgraph-id-vs-deployment-id 5.9 KB 700.29 KB 200.08%

@marcusrein marcusrein merged commit f3f26e8 into main Jan 8, 2024
3 checks passed
@marcusrein marcusrein deleted the subgraph-id-deployment-id-update branch January 8, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants