Skip to content

Debug config info #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2024
Merged

Debug config info #353

merged 4 commits into from
Oct 9, 2024

Conversation

carlosvdr
Copy link
Contributor

fixes #314

@carlosvdr carlosvdr requested a review from gusinacio October 7, 2024 20:17
@coveralls
Copy link

coveralls commented Oct 7, 2024 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 11261529170

Details

  • 0 of 19 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 70.518%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/config.rs 0 3 0.0%
service/src/main.rs 0 16 0.0%
Totals Coverage Status
Change from base Build 11261450609: -0.2%
Covered Lines: 4492
Relevant Lines: 6370
💛 - Coveralls

gusinacio
gusinacio reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It's only missing on service.

@carlosvdr carlosvdr requested a review from gusinacio October 8, 2024 20:12
@carlosvdr carlosvdr self-assigned this Oct 8, 2024
@carlosvdr carlosvdr marked this pull request as ready for review October 9, 2024 17:12
@gusinacio
Copy link
Contributor

Hello, this still needs to rebase and solve conflicts

gusinacio
gusinacio approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit 20b959d into main Oct 9, 2024
11 checks passed
@gusinacio gusinacio deleted the debug-config-info branch October 9, 2024 19:26
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gusinacio gusinacio gusinacio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlosvdr carlosvdr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update default log configuration to INFO

3 participants

@carlosvdr @coveralls @gusinacio