Skip to content

Conversation

carlosvdr
Copy link
Contributor

fixes #335

@carlosvdr carlosvdr self-assigned this Oct 8, 2024
@carlosvdr carlosvdr requested a review from gusinacio October 8, 2024 20:12
@coveralls
Copy link

coveralls commented Oct 8, 2024

Pull Request Test Coverage Report for Build 11260110816

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 39 of 39 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 70.708%

Files with Coverage Reduction New Missed Lines %
tap-agent/src/agent/sender_account.rs 3 92.92%
Totals Coverage Status
Change from base Build 11242773960: 0.1%
Covered Lines: 4596
Relevant Lines: 6500

💛 - Coveralls

@carlosvdr carlosvdr marked this pull request as ready for review October 9, 2024 17:43
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lovely work!

@gusinacio gusinacio merged commit 5ff0550 into main Oct 9, 2024
11 checks passed
@gusinacio gusinacio deleted the shared-env-var branch October 9, 2024 17:52
@github-actions github-actions bot mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Friendly environment variables setup

3 participants