Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto retry RAVs if sender denied #195

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

gusinacio
Copy link
Member

Close #177

Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio requested a review from aasseman May 28, 2024 23:24
@gusinacio gusinacio self-assigned this May 28, 2024
@coveralls
Copy link

coveralls commented May 28, 2024

Pull Request Test Coverage Report for Build 9278801427

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 17 (76.47%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 68.234%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_account.rs 13 17 76.47%
Totals Coverage Status
Change from base Build 9259874501: 0.02%
Covered Lines: 3729
Relevant Lines: 5465

💛 - Coveralls

@aasseman aasseman changed the title feat: retry if denied feat: auto retry RAVs if sender denied May 29, 2024
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing improvements to the comments

tap-agent/src/agent/sender_account.rs Outdated Show resolved Hide resolved
tap-agent/src/agent/sender_account.rs Outdated Show resolved Hide resolved
tap-agent/src/agent/sender_account.rs Outdated Show resolved Hide resolved
Co-authored-by: Alexis Asseman <alexis@semiotic.ai>
@gusinacio gusinacio force-pushed the gusinacio/retry-when-denied branch from 2d07557 to f6455f6 Compare May 29, 2024 01:29
@aasseman aasseman merged commit f430708 into main May 29, 2024
9 checks passed
@aasseman aasseman deleted the gusinacio/retry-when-denied branch May 29, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat.Req] Retry rav requests when senders are on a blocklist
3 participants