Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty response err on GQL return empty list #210

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fix empty response err on GQL return empty list #210

merged 2 commits into from
Jun 17, 2024

Conversation

aasseman
Copy link
Contributor

@aasseman aasseman force-pushed the aasseman/fix-gql-emptyresponse-2 branch from ac1e485 to f990350 Compare June 17, 2024 18:40
@aasseman
test(common): monitor w/ empty list GQL response
8d0d053 
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@aasseman
fix(common): Empty response err on GQL return empty list
6747363 
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@aasseman aasseman force-pushed the aasseman/fix-gql-emptyresponse-2 branch from f990350 to 8d0d053 Compare June 17, 2024 18:49
@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 9553202000

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 66.897%
Totals Coverage Status
Change from base Build 9509816994: 0.08%
Covered Lines: 3874
Relevant Lines: 5791
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 9553202000

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 66.897%
Totals Coverage Status
Change from base Build 9509816994: 0.08%
Covered Lines: 3874
Relevant Lines: 5791
💛 - Coveralls

@github-actions GitHub Actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 9553202000

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 66.897%
Totals Coverage Status
Change from base Build 9509816994: 0.08%
Covered Lines: 3874
Relevant Lines: 5791
💛 - Coveralls

@aasseman aasseman marked this pull request as ready for review June 17, 2024 20:09
gusinacio
gusinacio approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman merged commit d8bb519 into main Jun 17, 2024
9 checks passed
@aasseman aasseman deleted the aasseman/fix-gql-emptyresponse-2 branch June 17, 2024 21:21
@aasseman aasseman mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

@carlosvdr carlosvdr Awaiting requested review from carlosvdr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aasseman @gusinacio