Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move graph-node instance to main #28

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

aasseman
Copy link
Contributor

Small change that will make it easier to share the graph-node instance wrapper with other flows, such as the allocation monitor.

@aasseman aasseman requested a review from hopeyen August 12, 2023 01:36
@aasseman aasseman self-assigned this Aug 12, 2023
Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring of graph-node made sense, though I think Graph node / Query processor shouldn't track the endpoint for network subgraph. Maybe it is worth having a separate network_subgraph client to execute queries with?

Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
@aasseman aasseman force-pushed the aasseman/query_processor_refactor branch from 75c0e86 to 12c47a2 Compare August 15, 2023 20:26
@aasseman
Copy link
Contributor Author

Rebased onto latest main

@aasseman aasseman merged commit 2b87043 into main Aug 15, 2023
4 checks passed
@aasseman aasseman deleted the aasseman/query_processor_refactor branch August 15, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants