Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update copyright headers #307

Merged
merged 2 commits into from
Sep 17, 2024
Merged

chore: update copyright headers #307

merged 2 commits into from
Sep 17, 2024

Conversation

carlosvdr
Copy link
Collaborator

closes #85

@carlosvdr carlosvdr self-assigned this Aug 29, 2024
@coveralls
Copy link

coveralls commented Aug 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10633066336

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 68.245%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 98.21%
Totals Coverage Status
Change from base Build 10582644416: -0.02%
Covered Lines: 4208
Relevant Lines: 6166
💛 - Coveralls

aasseman
aasseman suggested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The related CI check needs to be adjusted too: https://github.com/graphprotocol/indexer-rs/blob/cbbe1f589a38356c34b2577bdf6af13a1055d4c9/.github/workflows/license_headers_check.yml

However, I don't understand why it didn't scream here 🤔

aasseman
aasseman approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this boring task 🙏

@gusinacio gusinacio self-requested a review September 17, 2024 15:58
@aasseman aasseman merged commit 984637b into main Sep 17, 2024
10 checks passed
@aasseman aasseman deleted the header-update branch September 17, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman approved these changes

@gusinacio gusinacio gusinacio approved these changes

Assignees

@carlosvdr carlosvdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlosvdr @coveralls @gusinacio @aasseman