-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ordering option for action queries #457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
changed the title
indexer-cli,-common: ordering action queries
Add ordering option for action queries
Aug 11, 2022
fordN
reviewed
Aug 17, 2022
packages/indexer-common/src/indexer-management/__tests__/actions.ts
Outdated
Show resolved
Hide resolved
packages/indexer-common/src/indexer-management/__tests__/actions.ts
Outdated
Show resolved
Hide resolved
fordN
reviewed
Aug 17, 2022
hopeyen
force-pushed
the
hope/ordering-actions
branch
from
August 18, 2022 22:26
c8822b5
to
952be04
Compare
fordN
reviewed
Aug 22, 2022
- Use orderBy and orderDirection inputs to align with other Graph Protocol GraphQL APIs
hopeyen
force-pushed
the
hope/ordering-actions
branch
from
August 22, 2022 22:55
d9b4fa5
to
0686108
Compare
fordN
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #442
Updated the actions graphQL schema to include sorting by inputs. Now indexers can supply
orderBy
and/ororderDirection
when they query for actions. Default: action id, ascending order.Example to query through the indexer-cli