Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AQI: actions delete command #491

Merged
merged 1 commit into from
Oct 7, 2022
Merged

AQI: actions delete command #491

merged 1 commit into from
Oct 7, 2022

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Oct 3, 2022

  • Add indexer actions delete command to delete actions by IDs in indexer-cli

example

$HELP - graph indexer actions delete [options] [<actionID1> ...]

 ./bin/graph-indexer indexer actions delete 13 16 37
✔ Processed input parameters
✔ 3 actions deleted

 ./bin/graph-indexer indexer actions delete 8 9 10                            
✔ Processed input parameters
✖ [GraphQL] Delete action failed: No action items found with id in [8,9,10]

If useful, we can delete all actions by a certain status, but I'm worried if it is too easy? Indexers could also get with filters and then feed in action ids as an array

@hopeyen hopeyen requested a review from fordN October 4, 2022 14:58
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@hopeyen hopeyen merged commit e43f121 into main Oct 7, 2022
@hopeyen hopeyen deleted the hope/aqi-actions-delete branch October 7, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

2 participants