indexer-common,cli: actions update command #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fordN
requested review from
hopeyen and
tilacog
and removed request for
hopeyen
fordN
force-pushed
the
ford/actions-update-command
branch
5 times, most recently
from
9475fed
to
d5a6bf2
Compare
fordN
force-pushed
the
ford/actions-update-command
branch
from
d5a6bf2
to
cd6fd7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an
actions update ...command for updating one or more actions in the action queue. In order to support this command to update many actions in a single request anupdateActionsresolver has been added as well.In the CLI the user can use options to filter the actions that will be updated and the user can provide key value pairs for the action keys that will be updated.
Example usage, update all failed, reallocate actions to have force=true:
Along with the added functionality a new test of the updateActions resolver has been included. In a subsequent PR I'll add CLI level tests of success and failure modes for the update command.
Shout out to @hopeyen for doing most of the work here on this feature! I was just there to do some final interface updates and push it across the finish line.