Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer-agent: Remove networkCurrentEpoch() from critical path #602

Merged

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Feb 10, 2023

The networkCurrentEpoch() function requires that the protocol chain be registered with the Epoch Block Oracle as an index chain. There may be cases where the protocol chain is not registered as an index chain; we don't want to block the indexer-agent reconciliation loop.

- The networkCurrentEpoch() function requires that the protocol chain
be registered with the Epoch Block Oracle as an index chain. There may
be cases where the protocol chain is not registered as an index chain;
we don't want to block the indexer-agent reconciliation loop
@fordN fordN requested a review from tilacog February 10, 2023 19:54
@fordN fordN self-assigned this Feb 10, 2023
@fordN fordN added indexer-agent enhancement New feature or request labels Feb 10, 2023
Copy link
Contributor

@tilacog tilacog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fordN fordN merged commit b090eb0 into main Feb 10, 2023
@fordN fordN deleted the ford/remove-requirement-protocol-chain-registered-as-index-chain branch February 10, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request indexer-agent
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

2 participants