common: refactor epoch sync check when resolving current epoch block #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilacog
force-pushed
the
tiago/refactor-valid-epoch-block
branch
2 times, most recently
from
1e78e66
to
e7ed47e
Compare
fordN
reviewed
Feb 11, 2023
|
I ended up with an I didn't force-pushed to keep means of comparison, but I pretend to squash the merge commit once approved. |
fordN
requested changes
Feb 11, 2023
tilacog
force-pushed
the
tiago/refactor-valid-epoch-block
branch
from
299e359
to
06a6e15
Compare
|
Force pushed to squash irrelevant commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforces that the Epoch Subgraph is at least one epoch away from the Epoch Manager.
Also, checks for the catastrophic case when the former is ahead of the latter.