Avoid race conditions when queuing actions (hopefully fixes #879) #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hActions This can be useful in situations where the actions need to be queried in the context of a transcation, such as when queuing a new action and wanting to check for duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the existing actions that the new actions are compared against to check for duplicates are queried outside the Sequelize transaction that will eventually write the action to the db. We've noticed that duplicates happen when two actions are added to the database in quick succession (<2s). By performing both the existing action queries and the database write within the same transaction, this hopefully won't happen any more.
This hopefully fixes duplicate actions being added to the queue (#879).